pmatilai commented on this pull request.


> @@ -307,8 +337,8 @@ static int runGPG(sigTarget sigt, const char *sigfile)
     Fclose(fnamedPipe);
     fnamedPipe = NULL;
 
-    (void) waitpid(pid, &status, 0);
-    pid = 0;
+    (void) waitpid(gpgPid, &status, 0);

Hmm, what if we get a SIGCHLD in the meanwhile? That'd set gpgPid to 0, which 
would turn the above into waitpid(0, ...) which doesn't seem right.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-323627595
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to