@s-t-e-v-e-n-k commented on this pull request.


> -                        dep_normalized_name = dep.key
+                        dep_normalized_name = dep.name.lower().replace('_', 
'-')
 
                     if args.legacy:
-                        name = 'pythonegg({})({})'.format(pyver_major, dep.key)
+                        name = 'pythonegg({})({})'.format(pyver_major, 
dep.name.lower())

Because dep.key is from setuptools' pkg_resources.Requirement and 
packaging.Requirement does not include it -- I'm not against creating a 
subclass of packing.Requirement here and including a key property that returns 
self.name.lower()

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#discussion_r493154379
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to