@torsava commented on this pull request.
> else:
- dep_normalized_name = dep.key
+ dep_normalized_name = dep.key.replace('_', '-')
The newest version looks good to me, and tests are passing.
The [documentation for
pkg_resources](https://setuptools.readthedocs.io/en/latest/pkg_resources.html)
says about `key`: An all-lowercase version of the project_name, useful for
comparison or indexing.
>From there you have to look up `project_name` and then `safe_name` function
>which generates it. So if we go by documentation, dots are not allowed in
>`key`. However, if you actually test it, they are there.
What do you think, @hroncok ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#discussion_r494166167_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
