https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639

--- Comment #8 from Ben Rosser <rosser....@gmail.com> ---
I finally got around to working on this.

The dfhack build process creates an include file, "git-describe.h", which
contains the commit hash information that gets incorporated into the version
strings. Rather than patch the build process not to use this file, which seemed
overly invasive, I just wrote a new script (prepare-dfhack-release) to generate
it and prevented cmake from doing so.

The new script still does a (recursive) clone of the dfhack repository. It then
extracts all the relevant git information and uses it to create git-describe.h
(which I include in the spec as a separate Source:). It also prints out the
"%global commitX ..." lines for each submodule.

The spec, then, refers to all 6 github URLs (dfhack and then 5 submodules). The
dfhack release is looked up by tag; the submodules by commit hash. I think this
is much cleaner than what was being done before.

I believe I incorporated your other comments as well. And I've updated to the
latest upstream release (0.44.03-beta1, supporting the newest release of Dwarf
Fortress).

Spec URL: https://mars.arosser.com/fedora/dwarffortress/rpmfusion/dfhack.spec
SRPM URL:
https://mars.arosser.com/fedora/dwarffortress/rpmfusion/dfhack-0.44.03-1.beta1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Reply via email to