https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Andrea Musuruane <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #11 from Andrea Musuruane <[email protected]> ---
I finally completed the review. There are some simple issues but I trust you
will handle the mandatory ones before committing.
Package is APPROVED!
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
=======
- Please rememeber you MUST remove this section:
# On CentOS, we want to strip the ".centos" bit of the dist tag.
# Credit to
https://serverfault.com/questions/688485/rpm-dist-tag-not-behaving-as-documented
# This should go away when the package is imported to RPM Fusion
%if 0%{?rhel} == 7
%define dist .el7
%endif
- This BR should no longer be needed: git
- All patches SHOULD have an upstream bug link or comment
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
- When a package only provides static libraries you MAY place all the static
library files in the *-devel subpackage.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Packaging_Static_Libraries_2
- %docdir contains a non documentation file:
/usr/share/doc/dfhack/docs/build.sh. You MUST not ship it. You can use the
%exclude directive.
- Please use %make_build instead of "make %{?_smp_mflags}"
- Large documentation MUST go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 1300480 bytes in 53 files.
See:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Documentation
- You SHOULD updated to the latest release (v0.44.05-r1)
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
Not a problem, since this is package will go to RPM Fusion nonfree
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package makes every effort to avoid having multiple, separate,
upstream projects bundled together
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: dfhack-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define dist .el7
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[?]: Package should compile and build into binary rpms on all supported
architectures.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: dfhack-0.44.03-1.beta1.fc28.x86_64.rpm
dfhack-devel-0.44.03-1.beta1.fc28.x86_64.rpm
dfhack-static-0.44.03-1.beta1.fc28.x86_64.rpm
dfhack-plugin-stonesense-0.44.03-1.beta1.fc28.x86_64.rpm
dfhack-debuginfo-0.44.03-1.beta1.fc28.x86_64.rpm
dfhack-debugsource-0.44.03-1.beta1.fc28.x86_64.rpm
dfhack-0.44.03-1.beta1.fc28.src.rpm
dfhack.x86_64: E: devel-dependency ruby-devel
dfhack.x86_64: E: explicit-lib-dependency ruby-libs
dfhack.x86_64: W: spelling-error %description -l en_US bugfixes -> bug fixes,
bug-fixes, suffixes
dfhack.x86_64: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
dfhack.x86_64: W: spelling-error %description -l en_US autodump -> auto dump,
auto-dump, autodidact
dfhack.x86_64: W: spelling-error %description -l en_US modders -> madders,
molders, dodders
dfhack.x86_64: W: spelling-error %description -l en_US raws -> wars, raw, craws
dfhack.x86_64: W: spelling-error %description -l en_US inits -> units, nits,
snits
dfhack.x86_64: W: dangling-relative-symlink
/usr/lib/.build-id/43/5b449e345c7a8faee5bb5a65c6861f8a8aef42
../../../../usr/lib64/dfhack/hack/plugins/stonesense.plug.so
dfhack.x86_64: W: no-manual-page-for-binary dfhack
dfhack.x86_64: W: no-manual-page-for-binary dfhack-run
dfhack.x86_64: W: no-manual-page-for-binary dwarffortress-hacked
dfhack-devel.x86_64: W: only-non-binary-in-usr-lib
dfhack-devel.x86_64: W: no-documentation
dfhack-static.x86_64: W: no-documentation
dfhack-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
dfhack-debugsource.x86_64: W: no-documentation
dfhack.src: W: spelling-error %description -l en_US bugfixes -> bug fixes,
bug-fixes, suffixes
dfhack.src: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
dfhack.src: W: spelling-error %description -l en_US autodump -> auto dump,
auto-dump, autodidact
dfhack.src: W: spelling-error %description -l en_US modders -> madders,
molders, dodders
dfhack.src: W: spelling-error %description -l en_US raws -> wars, raw, craws
dfhack.src: W: spelling-error %description -l en_US inits -> units, nits, snits
dfhack.src: W: strange-permission prepare-dfhack-release 775
dfhack.src:231: W: rpm-buildroot-usage %build %cmake ..
-DCMAKE_BUILD_TYPE:string=Release
-DCMAKE_INSTALL_PREFIX=%{buildroot}%{_libdir}/dfhack
-DDFHACK_BUILD_ARCH=%{dfhack_arch} %{?fedora:-DBUILD_STONESENSE:BOOL=True
-DSTONESENSE_INTERNAL_SO=OFF} -DDOWNLOAD_RUBY=OFF
7 packages and 0 specfiles checked; 3 errors, 22 warnings.
Requires
--------
dfhack-static (rpmlib, GLIBC filtered):
dfhack(x86-64)
dfhack-debugsource (rpmlib, GLIBC filtered):
dfhack (rpmlib, GLIBC filtered):
/bin/sh
dwarffortress
ld-linux-x86-64.so.2()(64bit)
libc.so.6()(64bit)
libdfhack-client.so()(64bit)
libdfhack.so()(64bit)
libdl.so.2()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
liblua.so()(64bit)
libm.so.6()(64bit)
libprotobuf-lite.so()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.5)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
ruby
ruby-devel
ruby-libs
valgrind
dfhack-debuginfo (rpmlib, GLIBC filtered):
dfhack-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
dfhack(x86-64)
dfhack-static(x86-64)
dfhack-plugin-stonesense (rpmlib, GLIBC filtered):
dfhack(x86-64)
liballegro.so.5.2()(64bit)
liballegro_color.so.5.2()(64bit)
liballegro_font.so.5.2()(64bit)
liballegro_image.so.5.2()(64bit)
liballegro_primitives.so.5.2()(64bit)
liballegro_ttf.so.5.2()(64bit)
libc.so.6()(64bit)
libdfhack.so()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libprotobuf-lite.so()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
Provides
--------
dfhack-static:
dfhack-static
dfhack-static(x86-64)
dfhack-debugsource:
dfhack-debugsource
dfhack-debugsource(x86-64)
dfhack:
bundled(jsoncpp)
bundled(lua)
bundled(protobuf)
bundled(tinythread)
bundled(tinyxml)
dfhack
dfhack(x86-64)
libdfhack-client.so()(64bit)
libdfhack.so()(64bit)
liblua.so()(64bit)
libprotobuf-lite.so()(64bit)
dfhack-debuginfo:
debuginfo(build-id)
dfhack-debuginfo
dfhack-debuginfo(x86-64)
dfhack-devel:
dfhack-devel
dfhack-devel(x86-64)
pkgconfig(dfhack)
dfhack-plugin-stonesense:
dfhack-plugin-stonesense
dfhack-plugin-stonesense(x86-64)
stonesense
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4
[Bug 4] Tracker: Accepted packages.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
