https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
--- Comment #9 from Andrea Musuruane <musur...@gmail.com> ---
(In reply to Ben Rosser from comment #8)
> I finally got around to working on this.
Hi Ben!
Sorry for taking so long just to have a look.
> The dfhack build process creates an include file, "git-describe.h", which
> contains the commit hash information that gets incorporated into the version
> strings. Rather than patch the build process not to use this file, which
> seemed overly invasive, I just wrote a new script (prepare-dfhack-release)
> to generate it and prevented cmake from doing so.
I'm glad to see that the size of the src.rpm has been greatly reduced.
BTW, I guess you can drop BR'ing git from:
BuildRequires: git, gcc, cmake, zlib-devel, mesa-libGL-devel
> The new script still does a (recursive) clone of the dfhack repository. It
> then extracts all the relevant git information and uses it to create
> git-describe.h (which I include in the spec as a separate Source:). It also
> prints out the "%global commitX ..." lines for each submodule.
It seems fine to me. Just add some instructions on how to use the
"prepare-dfhack-release" script.
It should be enough to edit the first line:
# To update dfhack to a new release, first run "prepare-dfhack-release
RELEASE_NAME"
> The spec, then, refers to all 6 github URLs (dfhack and then 5 submodules).
> The dfhack release is looked up by tag; the submodules by commit hash. I
> think this is much cleaner than what was being done before.
I agree. It's also more readable now.
IIRC using the %setup macro is the preferred way to unpack additional sources.
http://www.tldp.org/HOWTO/RPM-HOWTO/build.html
Do you think it is possible?
> I believe I incorporated your other comments as well. And I've updated to
> the latest upstream release (0.44.03-beta1, supporting the newest release of
> Dwarf Fortress).
I'll try to make a full review in the coming days.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
