On Wed, Jan 21, 2009 at 9:27 AM, aidy lewis <aidy.le...@googlemail.com> wrote: > Hi David, > On 21/01/2009, David Chelimsky <dchelim...@gmail.com> wrote: > >> text on the button that is deemed to have business value, then you >> might say "And I click 'Request Service'" - but if you're referencing >> DOM IDs or HTML element names like 'submit', I'd hide those. > > However we could get a lot of re-use in the user steps if we have > step definitions like these: > > When /^clicks '(+)' link$/ do |text| > browser.link(:text, Regexp.new(value)).click > end > > When /^clicks '(+)' button$/ do |text| > browser.button(:value, Regexp.new(value)).click > end > > > When clicks 'Submit' link > When clicks 'Submit' button > When clicks 'New' link > When clicks 'New' button
The important part of what I was saying was to avoid hidden elements (DOM IDs and element names). If the label that is visible in the browser says "Submit", then this is OK IMO. > I personally don't think it is a crime for the tester to change the > acceptance steps as long as the 'user' can easily follow the > narrative. Don't worry, you're not under arrest. At least not for this transgression :) > A lot of the other user-steps could be wrapped-up in a more > 'declarative' fashion. > > Aidy _______________________________________________ rspec-users mailing list rspec-users@rubyforge.org http://rubyforge.org/mailman/listinfo/rspec-users
