Re: Making rsync compile under Mac OS X 10.3.9 with extended attributes

[Vitorio Machado]

v0.5 is out!

Changelog:
0.5 - Corrected path parser bug that would break if part of the path was
      an alias and not a folder.
      Corrected the fifos, block and character devices detection.

0.4 - Rewrited getxattr, setxattr to don't use getattrlist/setattrlist
      Corrected a bug on path2fsref where non-ASCII characters bugged

          PS: This patch goes fine with rsync 3.0.0pre10

0.3 - Corrected a bug that makes files with resource fork invisible

0.2 - Corrected a pointer bug in sys_lgetxattr and sys_lsetxattr
      Corrected a bracket problem in sys_llistxattr

0.1 - First alpha compiling version

There is still a strange little bug:
Running

for the first time gives an error

The dir dir-with-flags it's created and appears to have the good times:

directory: "/Volumes/Dst/80-rsync-test/Src/60-bsd-flags/dir-with-flags"
attributes: avbstcLinmed
created: 02/17/2008 21:58:36
modified: 02/17/2008 21:58:36

directory: "/Volumes/Src/60-bsd-flags/dir-with-flags"
attributes: avbstcLinmed
created: 02/17/2008 21:58:36
modified: 02/17/2008 21:58:36





Vitorio

recv_files(Src/60-bsd-flags/file-with-flags)
got file_sum

fsreffrompath(Src/60-bsd-flags/.file-with-flags.CqNyUX, 0xbfffcc00);
PWD=/Volumes/Dst/80-rsync-test
name=.file-with-flags.CqNyUX
list lenght=21, list content:
com.apple.FinderInfo

value=
fsreffrompath(Src/60-bsd-flags/.file-with-flags.CqNyUX, 0xbfffca80);
PWD=/Volumes/Dst/80-rsync-test
name=.file-with-flags.CqNyUX

touch_up_dirs: Src/60-bsd-flags (11)
set modtime of Src/60-bsd-flags to (1203281916) Sun Feb 17 21:58:36 2008
touch_up_dirs: Src/60-bsd-flags/dir-with-flags (22)

recv_files(Src/60-bsd-flags/dir-with-flags)
sys_llistxattr(Src/60-bsd-flags/dir-with-flags, 0x2800400, 1024);
fsreffrompath(Src/60-bsd-flags/dir-with-flags, 0xbfffcc60);
PWD=/Volumes/Dst/80-rsync-test
name=dir-with-flags
list lenght=21, list content:
com.apple.FinderInfo

value=
fsreffrompath(Src/60-bsd-flags/dir-with-flags, 0xbfffcae0);
PWD=/Volumes/Dst/80-rsync-test
name=dir-with-flags

recv_files(Src/70-extended-attrs)

Rewrited listxattr to better handle fifos, block and character devices sudo ./rsync -aHXNvvvv --fileflags /Volumes/Src /Volumes/Dst/80-rsync-test rsync: failed to set times on "/Volumes/Dst/80-rsync-test/Src/60-bsd-flags/dir-with-flags": Operation not permitted (1) iLaG:~/Desktop/rsync-3.0.0pre10 patched lag$ /Developer/Tools/GetFileInfo /Volumes/Dst/80-rsync-test/Src/60-bsd-flags/dir-with-flags iLaG:~/Desktop/rsync-3.0.0pre10 patched lag$ /Developer/Tools/GetFileInfo /Volumes/Src/60-bsd-flags/dir-with-flags If I rerun the rsync it makes no error. If I run rsync for the first time without -X option it makes no error neither. What's strange is that the time setting have nothing to do with my mods. What I've seen is that crtimes patch uses getattrlist/setattrlist that I'm avoiding because it doesn't have the same behaviour on 10.3 and 10.4 (man getattrlist doesn't even exist on 10.3, the function was undocumented). But I don't know why it doesn't bug running without -X, as crtimes.diff is still active. There is maybe a bug mixing Carbon and getattrlist calls. I'm attaching the verbose log of the operations before the error. And the patch, of course! sys_llistxattr(Src/60-bsd-flags/.file-with-flags.CqNyUX, 0x2800400, 1024); sys_lsetxattr(Src/60-bsd-flags/.file-with-flags.CqNyUX, com.apple.FinderInfo, 32); set modtime of Src/60-bsd-flags/.file-with-flags.CqNyUX to (1203281916) Sun Feb 17 21:58:36 2008 renaming Src/60-bsd-flags/.file-with-flags.CqNyUX to Src/60-bsd-flags/file-with-flags set modtime of Src/60-bsd-flags/dir-with-flags to (1203281916) Sun Feb 17 21:58:36 2008 sys_lsetxattr(Src/60-bsd-flags/dir-with-flags, com.apple.FinderInfo, 32); set modtime of Src/60-bsd-flags/dir-with-flags to (1203281916) Sun Feb 17 21:58:36 2008 rsync: failed to set times on "/Volumes/Dst/80-rsync-test/Src/60-bsd-flags/dir-with-flags": Operation not permitted (1)

rsync10.3xattr_supportv0.5.diff
Description: Binary data

-- 
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html