On Thu, Jul 07, 2016 at 08:12:09AM +0200, Stephan Roslen wrote:
> > Within the current sunxi clk structure, the LOSC is registered as a fixed
> > 32.768 KHz clk. So this patch actually makes things right.
> 
> In this case it should still be addressed somewhere in drivers/clk/sunxi, not 
> in drivers/rtc, I guess? Would you prefer setting the external 32.768 KHz 
> crystal
> as hard coded default instead of providing the muxer? It could be considered 
> okay,
> for the data sheet seems to demand presence of the external oscillator and 
> there
> is absolutely no use in a 32KHz +- 20% oscillator, if a 32.768KHz crystal is
> available.

Yes, poking into the registers in drivers/clk would also work.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups 
"rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Attachment: signature.asc
Description: PGP signature

Reply via email to