Chris,
I will go through the changes, it will take some time to
verify :)
I found one more things :
[E]----|
(5,0) |
| |
| |
[R] [D]---[C]
(0,0) (4,0) (3,0)
| |
| |
[A]---------[B]
(1,0) (2,0)
In above 6 router topology, there are no ears.
As per psudocode only GADAG root [R] will be assigned with IN_GADAG
flag. A,B,C,D,E will not have the flag IN_GADAG set.
Thanks & Regards
Anil S N
"Be liberal in what you accept, and conservative in what you send" - Jon Postel
From: Chris Bowers [mailto:[email protected]]
Sent: 18 June 2015 03:58
To: Anil Kumar S N (VRP Network BL); Gábor Sándor Enyedi;
[email protected]; Alia Atlas; [email protected]
Cc: [email protected]; [email protected]
Subject: RE: [rtgwg] draft-ietf-rtgwg-mrt-frr-algorithm-03
Anil,
Thanks for pointing this out. Construct_Ear() mentions identifying a
cut-vertex in a comment, but doesn't actually set it explicitly. I added it as
below, as reflected in the github diff link.
Construct_Ear(x, Stack, intf, ear_type)
...
if (ear_type is CHILD) and (cur_node is x)
// x is a cut-vertex and the local root for
// the block in which the ear is computed
x.IS_CUT_VERTEX = true <<< New line here
localroot = x
else
https://github.com/cbowers/draft-ietf-rtgwg-mrt-frr-algorithm/commit/6a92a3fe9f578af2566d0dbb042181cb22469c57
With respect to identifying cut-links, I'd like to propose the following
changes to the Add_Undirected_Links() to have it deal better with
parallel-links from the block root (cut-vertices or the GADAG root) to another
node. When adding undirected links to the GADAG, links connecting the block
root to other nodes in that block need special handling because the topological
order will not always give the right answer for links involving the block root.
There are three cases below.
case 1a) If the undirected link in question has another parallel link between
the same two nodes that is already directed, then the direction of the
undirected link can be inherited from the previously directed link.
case 1b) In the case of parallel cut links, we set all of the parallel links to
both INCOMING and OUTGOING.
case 2) Otherwise, the undirected link in question is set to OUTGOING from the
block root node.
With this version of Add_Undirected_Links(), a cut-link can be identified by
the fact that it will be directed both INCOMING and OUTGOING in the GADAG.
I put proposed pseudo-code to replace figure 18 in the github diff below.
https://github.com/cbowers/draft-ietf-rtgwg-mrt-frr-algorithm/commit/5d5e5c9c74ef963195e29cb2e7b449c8884facd4
From: Anil Kumar S N (VRP Network BL) [mailto:[email protected]]
Sent: Monday, June 15, 2015 3:25 AM
To: Chris Bowers; Gábor Sándor Enyedi;
[email protected]<mailto:[email protected]>; Alia Atlas;
[email protected]<mailto:[email protected]>
Cc: [email protected]<mailto:[email protected]>;
[email protected]<mailto:[email protected]>
Subject: RE: [rtgwg] draft-ietf-rtgwg-mrt-frr-algorithm-03
Hi Chris,
I couldn't find psudocode for indentifying and marking a link
as cut-link and vertex as cut-vertex. Please correct me if I am wrong.
Thanks & Regards
Anil S N
"Be liberal in what you accept, and conservative in what you send" - Jon Postel
_______________________________________________
rtgwg mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/rtgwg
