On 12/15/25 6:03 PM, Jarek Prokop wrote:
On 12/15/25 4:28 PM, [email protected] wrote:
On 12/15/25 4:01 PM, Mamoru TASAKA via ruby-sig wrote:
-------------------------------------
○ vagrant-libvirt
https://copr.fedorainfracloud.org/coprs/mtasaka/rubydep-heavypkg-40-01/build/9904657/
Several failures, but many (or all) of these looks like
Failures:
1) VagrantPlugins::ProviderLibvirt::Config#finalize! @uri should
handle inputs {uri:
"qemu+libssh2://user@remote/system?known_hosts=/home/user/.ssh/known_hosts"}
with env ()
Failure/Error: params = CGI.parse(uri.query)
NoMethodError:
undefined method 'parse' for class CGI
# ./lib/vagrant-libvirt/config.rb:1330:in
'VagrantPlugins::ProviderLibvirt::Config#finalize_from_uri'
# ./lib/vagrant-libvirt/config.rb:939:in
'VagrantPlugins::ProviderLibvirt::Config#finalize!'
# ./spec/unit/config_spec.rb:317:in 'block (5 levels) in <top
(required)>'
# ./spec/support/unit_context.rb:51:in 'block (3 levels) in
<top (required)>'
# ./spec/support/unit_context.rb:43:in 'block (2 levels) in
<top (required)>'
# /usr/share/rubygems/rubygems.rb:303:in 'Kernel#load'
# /usr/share/rubygems/rubygems.rb:303:in
'Gem.activate_and_load_bin_path'
# /usr/share/rubygems/rubygems.rb:303:in 'Kernel#load'
# /usr/share/rubygems/rubygems.rb:303:in
'Gem.activate_and_load_bin_path'
So this is CGI deprecation for ruby4.0.0dev (maybe I have already
written this before)
I'll take a look at this.
Indeed requires CGI. With it, the test suite passes. I have prepared a
PR: https://src.fedoraproject.org/rpms/vagrant-libvirt/pull-request/14
But it needs the cgi gem first. I have submitted a review request:
https://bugzilla.redhat.com/show_bug.cgi?id=2422322
Not sure if there's an approach that'd make it work with also Ruby
3.4, but since it will be superseded soon-ish, I don't think we should
much time on that idea.
Thanks to Mamoru's suggestion
https://src.fedoraproject.org/rpms/vagrant-libvirt/pull-request/14#comment-298172
of the URI.decode_www_form,
I dropped the rubygem-cgi review (since it currently seems as the only
package that would require it) and instead dropped CGI requirement from
vagrant-libvirt altogether.
Thanks,
Jarek
--
_______________________________________________
ruby-sig mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
