On 7/12/07, Gabe da Silveira <[EMAIL PROTECTED]> wrote: > > I've got a couple small patches that are quite helpful and minimally > invasive that I'd love to get out of my vendor/rails so I can start > work on new patches with a clean edge rails (without checking out > another copy). If any core member has time to take a look at these > and either commit these or give me some feedback I'd really appreciate > it: > > http://dev.rubyonrails.org/ticket/8683 > > Koz looked at this one and asked for a test 3 weeks ago, which I > provided, but I haven't heard back. This one is particularly useful > for development because without it, Template Missing errors don't > actually say what template was requested (broken since the addition of > multiple controller view paths).
Applied. Thanks! > http://dev.rubyonrails.org/ticket/8173 > > This one's been out there for several months with nary a comment > (other than "not so tiny", which I dispute). It makes XML testing > with assert_select work. The only condition under which it would > break someone's existing tests would be if they were sending content > type application/xhtml+xml (which no one does because IE doesn't > understand it) AND they were producing invalid XHTML (an unlikely > combination to say the least). So it seems like a no-brainer to me. > Jamis even blogged about a workaround > (http://weblog.jamisbuck.org/2007/1/4/assert_xml_select), so it's > surprising there's been no comment. assert_select and xml is way outside my comfort zone so I'll pass on this one. Anyone else have any comments on it? If you can get three regular contributors to report on the utility of the patch, and the implementation, I'd feel more comfortable applying it. -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
