How are css selectors useful when testing xml? Do you just use the element names?
As for the patch, you should probably use the lookup function in mime.rb instead of regexp matching. That'll remove the false positives On 7/13/07, Rob Sanheim <[EMAIL PROTECTED]> wrote: > > On 7/12/07, Gabe da Silveira <[EMAIL PROTECTED]> wrote: > > > > On 7/11/07, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > > > > > Applied. Thanks! > > > > Thank you! > > > > > > http://dev.rubyonrails.org/ticket/8173 > > > > > assert_select and xml is way outside my comfort zone so I'll pass on > > > this one. Anyone else have any comments on it? > > > > > > If you can get three regular contributors to report on the utility of > > > the patch, and the implementation, I'd feel more comfortable applying > > > it. > > > > I know there's gotta be people out there bitten by this one. If your > > XML schema contains auto-closing HTML tags (such as <area>) then > > testing with assert_select becomes unusable. The patch is so simple, > > if you're doing RESTful APIs and like the power of assert_select, > > please take 5 minutes to check it out. It'll save you a lot of ugly > > hacks. > > I've been bitten by this before, and would love to see assert_select > made more friendly for xml. > > - Rob > -- > http://robsanheim.com > > > > -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
