Gabe da Silveira wrote:
> I know there's gotta be people out there bitten by this one.

Yes. The case I got bitten by is the <link> element: in HTML it's 
self-closing, in feed XML it is not.

I currently use the method from 
http://weblog.jamisbuck.org/2007/1/4/assert_xml_select, which defines a 
separate assert method for the XML case.

It looks like the original assert_select plug-in may have had something 
similar in the form of assert_select_feed (it still features in Edge 
comments, but the code doesn't seem to have survived.)

I don't know of any reason not to fix up the underlying response as in 
your patch, though. Anyone? I do think the method name seems wrong now - 
it's not really an html_document you're returning. Should the fix really 
be applied in response_from_page_or_rjs?

I note that the patch fixes css_select too, as well as assert_select - 
it currently suffers from the same set of XML problems.

  --Anthony.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to