On 8/20/07, Courtenay <[EMAIL PROTECTED]> wrote: > Zing! You're right, of course. But my patch was specifically written > to be a simple drop-in replacement for the existing code, rather than > a huge freaking rewrite.
Yup, and I think that's totally fine; I definitely strayed from the central topic of the thread. Considering the benefits gained vs. the amount of code changed, I think your patch has definite value and I hope it does get committed. That said, and continuing my aside - > I actually tried rewriting it, but there are just too many > dependencies with the rest of the library, includling all that > alias_method_chain stuff. If it's felt that ActiveRecord* would benefit from some more extensive work, what's the best way to approach this? My feeling is that large patches are very unlikely to see any commit action, which is fair because they're difficult to grasp. The typical approach within a development team might be to create a branch, but I'm not sure that works within the Rails development process either. Any thoughts? James * or any other Rails framework for that matter, but most people seem to express this more-radical-refactoring urge with ActiveRecord -- * J * ~ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
