[email protected] said: > On 09/10/14 13:28, Martin Lucina wrote: > > [Cc-ing to the rumpkernel-users list, better discussed there rather than > > hidden away under many clicks of Github] > > Good idea. > > >> Looks good, except rump_pub_etfs_register(), like all rump_pub calls, > >> returns a NetBSD errno. So you can't use warn() there meaningfully. > > > > Right, in fact rump_etfs(3) says nothing about the return values of those > > functions; I just assumed they returned 0 on success and -1 on error (and > > set errno). Reading rumpvfs/rumpfs.c it turns out they actually return 0 > > on success and the NetBSD errno directly otherwise. > > Yea, the man page should say that. The problem is that I wrote it so > that I wouldn't have to look up the code all the time; I can never > remember the exact names of the constants, but I do remember the return > convention ;)
Ok, do you mind if I add RETURN VALUE sections to these manpages which state explicitly that these function return zero on success and a NetBSD errno on failure? If I make my changes as diffs against the manpages and send them to the list can you or Justin commit them to NetBSD, assuming you're happy with them? Martin ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho _______________________________________________ rumpkernel-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/rumpkernel-users
