[email protected] said: > On Tue, Oct 21, 2014 at 9:27 AM, Martin Lucina <[email protected]> wrote: > > Ok, do you mind if I add RETURN VALUE sections to these manpages which > > state explicitly that these function return zero on success and a NetBSD > > errno on failure? > > > > If I make my changes as diffs against the manpages and send them to the > > list can you or Justin commit them to NetBSD, assuming you're happy with > > them? > > Sure.
Here you go. I added the missing section to rump_etfs.3 and also added it to rump_lwproc.3 despite it repeating information already in the function descriptions -- speaking from experience I have been known to go search for RETURN VALUE in manpages in anger :-) I don't know if I should update the .Dd or not, no idea what the conventions for that in NetBSD are. ----- diff --git a/lib/librump/rump_lwproc.3 b/lib/librump/rump_lwproc.3 index 3aa2fdd..5c3e8dc 100644 --- a/lib/librump/rump_lwproc.3 +++ b/lib/librump/rump_lwproc.3 @@ -127,6 +127,15 @@ Returns curlwp or .Dv NULL if the current context is an implicit context. .El +.Sh RETURN VALUES +.Fn rump_pub_lwproc_rfork +and +.Fn rump_pub_lwproc_newlwp +return 0 on success or an errno indicating the reason for failure. +.Fn rump_pub_lwproc_curlwp +returns curlwp or +.Dv NULL +if the current context is an implicit context. .Sh SEE ALSO .Xr getpid 2 , .Xr rump 3 diff --git a/lib/librumpvfs/rump_etfs.3 b/lib/librumpvfs/rump_etfs.3 index f294c6e9..e1883d7 100644 --- a/lib/librumpvfs/rump_etfs.3 +++ b/lib/librumpvfs/rump_etfs.3 @@ -186,6 +186,9 @@ Remove etfs mapping for This routine may be called only if the file related to the mapping is not in use. .El +.Sh RETURN VALUES +.Nm +routines return 0 on success or an errno indicating the reason for failure. .Sh EXAMPLES Map a host image file to a mountable .Pa /dev/harddisk ------------------------------------------------------------------------------ _______________________________________________ rumpkernel-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/rumpkernel-users
