On Sat, 16 May 2009 22:31:45 +0200
Michal Nazarewicz <[email protected]> wrote:

> > On Sat, 16 May 2009 22:14:37 +0200
> > Michal Nazarewicz <[email protected]> wrote:
> >> Done. :) Modified code available at previous location[1].  "NEW"
> >> hiding was already in my version only had to add your code for
> >> hiding tab (renamed resource to autohide though).
> 
> Thomas Adam <[email protected]> writes:
> > Can you provide a patch file instead, please?  Otherwise I can't
> > easily see what's changed, and I refuse to do the diff myself.
> 
> Ah, that was tricky...  Wasn't sure what version I started my editions
> From ;) but turned out it was the latest.  And here it is:
> <http://home.elka.pw.edu.pl/~mnazarew/downloads/tabbed-1.25.diff>.

OK.  I am in the process of cleaning all of this up, since the people
who've tried have failed in the past, and I am arrogant enough to
assume I can actually do it properly.

Your patch, however, suffers some problems:

1.  You've gone and interlaced it with incorrect "style" cleanups; the
net-effect is:

- Distracting
- *Incorrect*

2.  You supply *NO* documentation (a la urxvt-perl's manpage) about
this feature.

I'm going to address point 1., and then bounce this back to you.

-- Thomas Adam

-- 
"It was the cruelest game I've ever played and it's played inside my
head." -- "Hush The Warmth", Gorky's Zygotic Mynci.

_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode

Reply via email to