On Sun, 17 May 2009 21:29:14 +0200 Michal Nazarewicz <[email protected]> wrote:
> > On Sat, 16 May 2009 22:31:45 +0200 > > Michal Nazarewicz <[email protected]> wrote: > >> Ah, that was tricky... Wasn't sure what version I started my > >> editions From ;) but turned out it was the latest. And here it is: > >> <http://home.elka.pw.edu.pl/~mnazarew/downloads/tabbed-1.25.diff>. > > Thomas Adam <[email protected]> writes: > > OK. I am in the process of cleaning all of this up, since the > > people who've tried have failed in the past, and I am arrogant > > enough to assume I can actually do it properly. > > > > Your patch, however, suffers some problems: > > > > 1. You've gone and interlaced it with incorrect "style" cleanups; > > the net-effect is: > > > > - Distracting > > Ok, wait a sec, because I'm not sure if I got you right. You're > saying that: > > $_[0]->{activity}++ > or $_[0]{term}{parent}->tab_activity ($_[0]); > > is not distracting? That's exactly what makes people say Perl is > write only language. > > > - *Incorrect* > > I haven't found any coding style guidelines so I'm not sure how can > you measure correctness. Anyways, if there is any, feel free to give > me a link to it, I'll then feel free to say that I don't care about > that, and then finally you'll free to reject my patch. Fair enough. It's not down to me to reject it, but since I am trying to avoid these very same issues with the existing patch that seems to have crept into yours, it's a little frustrating. I see changes like: - () + (); and: -} -else if +} elseif Those sorts of things are what I am referring to, as well as an increase of whitespace. > > 2. You supply *NO* documentation (a la urxvt-perl's manpage) about > > this feature. > > This is rather far from true. A short introduction is present in > source so claiming there is *NO* documentation is pure nonsense. Well, it needs to be documented in the manpage -- we don't generally point people to the documentation in the source file. :P -- Thomas Adam -- "It was the cruelest game I've ever played and it's played inside my head." -- "Hush The Warmth", Gorky's Zygotic Mynci. _______________________________________________ rxvt-unicode mailing list [email protected] http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
