> Michal Nazarewicz <[email protected]> wrote: >> I haven't found any coding style guidelines so I'm not sure how can >> you measure correctness. Anyways, if there is any, feel free to give >> me a link to it, I'll then feel free to say that I don't care about >> that, and then finally you'll free to reject my patch. Fair enough.
Thomas Adam <[email protected]> writes: > It's not down to me to reject it, but since I am trying to avoid these > very same issues with the existing patch that seems to have crept into > yours, it's a little frustrating. > > I see changes like: > > - () > + (); Come on, this is such a big issue? In fact, it increases readability, by introducing a simple, strict "put a semicolon after *every* instruction" rule rather then a vague "put a semicolon after *some* instructions." > -} > -else if > +} elseif Even original source code is inconsistent in that matter. > Those sorts of things are what I am referring to, as well as an > increase of whitespace. and putting additional white space is bad because the file is getting bigger, right? >>> 2. You supply *NO* documentation (a la urxvt-perl's manpage) about >>> this feature. >> This is rather far from true. A short introduction is present in >> source so claiming there is *NO* documentation is pure nonsense. > Well, it needs to be documented in the manpage -- we don't generally > point people to the documentation in the source file. :P Having source files documented is nice as well. :] Anyways, as said in previous posts, free time is not something I have so it may take me some time to fix the documentation. -- Best regards, _ _ .o. | Liege of Serenly Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +--<mina86*tlen.pl>--<jid:mina86*jabber.org>--ooO--(_)--Ooo--
pgpi8vmFWLmKi.pgp
Description: PGP signature
_______________________________________________ rxvt-unicode mailing list [email protected] http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
