Hello,

On Sun,  8 Jul 2012 12:46:17 -0400
Soheil Hassas Yeganeh <[email protected]> wrote:

> Wildcards for nx match are not correctly set. This patch fixes the wildcards
> for dl_src and dl_dst.

Thanks for the patch. However, I'm not sure what problem you try to
solve.

If dl_sr_mask or dl_dst_mask is a non-zero value, we have to use NXM
so checking them in match_tuple() doesn't make sense (flow_format()
has a bug, should check dl_src_mask too).

Well, flow_format() and match_tuple are really
outdated. send_flow_mod(), the user of them, doesn't work with OF1.2
and the latter. Probably, we should remove them. Using explicitly
NXTFlowMod is better if NXM is necessary.



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to