Hi Franco,
> Checking that the patch applies cleanly and making sure that
> doctests pass are an important part of the review process, and it
> seems to me that this won't be done properly this way. I'm worried
> that a particular patch might rely on some earlier work in the
> sage-combinat queue without the author of the patch knowing
> it. Since the review and doctesting would be done within the
> sage-combinat branch, everything would work, and we will end up
> automatically uploading patches to trac that will have broken
> doctests or that might not even apply successfully. Then Michael
> would get mad at us, and we don't want that.
Right. But that can probably be fixed if we add some provision that
the script should only pickup a patch that is lowest on the patch
queue, right after the sage-*.*.* patches and, possibly, previous
patches that have readily been posted to trac (in which case, the
script should probably mention the possible dependency).
What do you think?
In short our queue could look like:
sage-3.2.0.patch # concatenation of all patches already applied in sage
*.*.*
sage-3.4.0.patch
bla-posted.patch # patches posted to trac, not yet integrated
ble-posted.patch
bli-reviewed.patch # reviewed patches, waiting for the script to pick it up
blo-reviewed.patch
bly-final.patch # patches in need for review
abla-final.patch
able-reviewed.patch # a reviewed patch, but possibly having dependencies on
previous patches
abli-nt.patch # patches under development
Cheers,
Nicolas
--
Nicolas M. Thiéry "Isil" <[EMAIL PROTECTED]>
http://Nicolas.Thiery.name/
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
