On 08/ 3/10 11:07 AM, Simon King wrote:
Hi David!
On Aug 3, 10:23 am, "Dr. David Kirkby"<[email protected]>
wrote:
...
In fact, I've put back #9397 for review, as that is a much simpler change to the
current version of Singular - just a few lines to permit 64-bit builds on
Solaris/OpenSolaris and does not update the Singular version. The necessary
fixes are in the new Singular update, but that ticket has been open 6 months
now, and is still not concluded. So if Singular does not get updated, I'd like
to get #8059 merged, which I've tested on Linux, OS X, Solaris and OpenSolaris.
I've attached build logs on all systems to the trac ticket.
I am confused now. I thought:
- #8059 *is* about Singular update (namely to singular-3-1-1-4.spkg).
- It even builds on Cygwin.
I'm not surprised you are confused. I could not have made a better job of
confusing you if I had tried.
I meant to say I'd like to get #9397 merged if the Singular update stalls.
- One problem for #8059 was that nobody did "make ptestlong" on t2 --
I did, two hours ago, based on Sage-4.5.1, and so far there has been
no error!
- Another problem is that the patch singular-3-1-1-4.patch (which
needs to be applied in addition to the spkg) needs to be rebased for
Sage-4.5.2
So, if these are the only problems (correct me, if there is more) then
I am sure that after rebasing the patch #8059 can get a positive
review soon.
Cheers,
Simon
If that's the case, then it sounds good. But as you can see from the ticket,
there has been no updates to it.
As you say, nobody tested it on Solaris, though I did ask on the ticket if it
had been tested. I personally don't have the time to test everyone's patches on
't2'. I often get cc'ed on patches for me to report on how they work on Solaris,
but I simply don't have the time. Perhaps I should keep a list of who does this,
then cc them on my tickets and ask if my patches work on linux. They might get
rather annoyed - and rightly so.
Dave
--
To post to this group, send an email to [email protected]
To unsubscribe from this group, send an email to
[email protected]
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
