On 6/20/12 9:40 AM, John H Palmieri wrote:


On Tuesday, June 19, 2012 11:02:01 PM UTC-7, jason wrote:

    Around line 296 in SAGE_ROOT/spkg/bin/sage, there seems to be a
    check to
    see if we should make the DOT_SAGE directory in the sage_setup()
    funciton. The check is:

    if [ ! -d "$IPYTHON_DIR" ]; then
    mkdir -p "$DOT_SAGE"
    fi

    Why are we checking to see if IPYTHON_DIR is defined in order to see if
    we should create DOT_SAGE??


I thought that the check was

IPYTHONDIR="$DOT_SAGE/ipython" && export IPYTHONDIR
if [ ! -d "$IPYTHONDIR" ]; then
mkdir -p "$DOT_SAGE"
cp -r "$SAGE_ROOT/ipython" "$DOT_SAGE/"
fi

Yes, that makes a lot more sense. In looking into it more deeply, I realize the code I posted above is from the first patch at the ticket migrating us to IPython 0.12: http://trac.sagemath.org/sage_trac/attachment/ticket/12719/trac_12719_ROOT_configuration_files.patch

So I guess the question is really for Volker (who submitted that patch). Why do you just create $DOT_SAGE? I notice that the patch mentioned above deletes a lot of the $SAGE_ROOT/ipython files, so maybe the whole if check isn't necessary at all?



("-d" means "is a directory", not "is defined", by the way.)

Ah.  Thanks.

Jason

--
To post to this group, send an email to [email protected]
To unsubscribe from this group, send an email to 
[email protected]
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to