On 2015-05-06 20:00, Clemens Heuberger wrote:
I'm happy to switch to closed when I merge it, and not only when it tests ok.
The downside is that you'll get more emails as I'll inevitably have to reopen
tickets, but merging/unmerging is scripted anyways. Eventually the merge will be
done by a script, so ideally tickets will only stay for seconds in the
positive_review state then. Essentially, we'll get rid of positive_review state
and any opportunity to make changes. Which ends up being the same as just
agreeing not to make changes to positive_review tickets right now. We can also
enforce this (require trac admin permissions for changing away from
positive_review) if you don't trust others...
This thread did not get any more answers for ~ two weeks now.
I have the impression that this proposal here did not get negative reactions.
Fine, I'll give a negative reaction: I don't like that there is no
window of time to adjust a branch after positive_review. It can easily
happen that some trivial issue is found after positive_review, it can
also happen that a ticket got set to positive_review by accident.
And it just feels like an unneeded restriction that tickets shouldn't be
changed after positive_review: there is no fundamental reason why
positive_review should be final.
Jeroen.
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.
