Most of the mathematicians by training do a terrible job at code review in Sage, whereas the compsci people do much better. I'm guessing that this is because the latter actually contribute to other projects and get some exposure to how code review is done right, whereas the former only ever experience our own dysfunctional process. IMHO its becoming more and more of a ciclejerk where the only way to get something reviewed is having your buddy do it for you, which handily ensures that there will never be new developers coming to Sage that could endanger our position of power.
Examples of not "getting" code review from this thread: * At review of some small addition we start a general discussions about what Poset should do and then everybody votes on that * Dislike of change/design pattern/author/..., hence I'm not reviewing this * I just make some comments on the ticket but would never set it to positive review. On Monday, January 25, 2016 at 3:27:09 AM UTC-5, Jori Mäntysalo wrote: > > There was a discussion between I, Travis and Nathann about > HasseDiagram-Poset; maybe a year ago there was discussion about 'self' in > docstrings. > > I have made some simple functions to add to Sage. Most of them have been > reviewed and accepted. Now, if I ask Nathann to review a function that > uses Poset class only as a wrapper, he rejects them (but makes good > suggestions for the code). If Travis is reviewing, he rejects > modifications where "self" is changed to "this thing" (but makes good > suggestions for the docstring). (Well, I can also ask Frédéric and get a > positive review (with good comments about making the code > PEP-compliance).) > > This is kind of complicated. If this is just me, then forget this mail. > But do other have similar feelings about need of common view of some > details? > > -- > Jori Mäntysalo > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
