On Mon, Jan 25, 2016 at 8:28 AM, Nathann Cohen <[email protected]> wrote: >> Examples of not "getting" code review from this thread: >> * At review of some small addition we start a general discussions about what >> Poset should do and then everybody votes on that >> * Dislike of change/design pattern/author/..., hence I'm not reviewing this >> * I just make some comments on the ticket but would never set it to positive >> review. > > In the last two cases, I do not think that there is anything irregular > when the reviewer can explain: > 1) What he believes to be wrong > 2) Why > 3) How to fix it > > It is then the author's right to refuse the proposed changes, and it > is the reviewer's right to not accept a patch he disagrees with. > > And really, I don't think that we could devise a new set of rule that > could solve this kind of dead-end situations.
+1 The situation is a bit like peer-reviewed research papers, which sometimes do get rejected from journals [1]. This is not necessarily a bad thing. William [1] Yes, I realize that rewriting code for Sage to include in Magma (say) is more complicated than just resubmitting a paper. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
