On 17 December 2013 13:42, Nathann Cohen <[email protected]> wrote: >> +1, very good question. I also think that this is a major missing feature >> from sage-git. With the obsolete system of patches on Trac, at least one >> could easily see the code belonging to a given ticket. > > Well, here is my attempt at bringing this topic up, though you can see what > happened :-P > > https://groups.google.com/d/topic/sage-git/ZC5QB1o1JlE/discussion
I did read that discussion. My own situation was very much simpler, since the ticket has no dependencies and the patch (if I may call it that) only affected one file. I had also previously (4 months ago) looked at the ticket when there was only one commit on it; now there are 3. So I suppose one possibility is to look at all the commits which are mention on that ticket and compare each with its parent. For example git diff 94e3516^ 94e3516 shows me (I think) what changes were made by one of the commits. So as long as I can find out which commits are relevant, I can do it. On this ticket #8723 there are three commits and I just looked at each one's diff from its predecessor, and I can see what the author did. That's a good start! John > > Seeing the dependencies right now it terribly tricky if not totally > impossible. I now always add the trac number in the commit messages so that > this could be a bit clearer : > http://trac.sagemath.org/ticket/15521 > > But for the older tickets, i.e. before I thought of doing this, knowing what > there is to review and what belongs to another ticket is... > Well, hell : > http://trac.sagemath.org/ticket/15288 > (in the list of commits, all those which are older than "Orthogonal arrays" > belong to other tickets) > > Nathann > > -- > You received this message because you are subscribed to the Google Groups > "sage-git" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "sage-git" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
