Hello guys ! I just created ticket #16261 about this and uploaded my branch. It's funny that to make all tests pass I only had to add four "linear_combination_of_smith_form_gens"...
Now the problem is that I have no idea how to change .short_name() (which is called by __repr__), as I have no idea how to get back the signature of the abelian group. The one which is used by the elements ^^; If anybody can help me there, or take a technical look at this patch. I am afraid that I really know next to nothing about all the math/programming involved there. Nathann On 28 April 2014 17:36, John H Palmieri <[email protected]> wrote: > Here's something I find really confusing about additive abelian groups: > > sage: H = AdditiveAbelianGroup([0,2]) > sage: H((2,0)) > (0, 0) > sage: H(vector((2,0))) > (2, 0) > > sage: H((1,0)).order() > 2 > sage: H(vector((1,0))).order() > +Infinity > > This is terrible, and a symptom of what Nathann wants to fix. It should be > fixed. > > John > > > > > On Monday, April 28, 2014 8:27:45 AM UTC-7, Nathann Cohen wrote: >> >> > Moreover, how are you going to deprecate it? When is a deprecation >> > warning >> > shown? >> >> Ahahahah. That's an interesting question, but the current way being >> bad, there is absolutely no way that it will stay like that forever >> just because we don't know how to tell the users :-D >> >> I had something a bit unpleasant in mind... Just showing a deprecation >> warning in this __call__ function saying that the standard WILL >> change, and doing nothing... And removing the lines we need to remove >> one year from now. >> >> Nathann > > -- > You received this message because you are subscribed to a topic in the > Google Groups "sage-support" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/sage-support/yexpjig9BSg/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sage-support. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-support" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-support. For more options, visit https://groups.google.com/d/optout.
