#3943: [with patch, needs work] block designs patch
---------------------------+------------------------------------------------
Reporter: wdj | Owner: wdj
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.1.3
Component: combinatorics | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Comment (by wdj):
> 1. These need to be fixed:
> ...
> Missing documentation:
> * incidence_matrix(self):
I don't understand this. It had a docstring and a test.
> 2. Earlier, I made the comment "If you are comparing
> two lists of ints, block_cmp gives exactly the same
> output as cmp." This hasn't yet been addressed.
> I think you can just remove the function and
> replace calls to it with just cmp and be fine.
Sorry I forgot. Done now.
> 3. Like I said before, BlockDesign should be a class
> which inherits from the Incidence structure
> class-- not just a function which returns an
> incidence structure (e.g. Graph and DiGraph?
> inheriting from GenericGraph? in graph.py).
To me this makes mathematical sense so I added a
line
{{{
BlockDesign_generic = IncidenceStructure
}}}
but there are no methods I know of currently
(maybe this will change in the future) which
apply to block designs and not incidence structures.
> Does dual_block_design make sense as a function
> of just any incidence structure?
Yes.
> If so, maybe it should be called
> dual_incidence_structure. Either way it should
> not call BlockDesign unless it is guaranteed to
> be one.
Done. I added an option method="gap" as well.
Please apply the 7 patches in order to 3.1.3.alpha1. They pass sage -t
-optional.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3943#comment:29>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
