#4884: [with patch; needs review] Make colormap handling better
-------------------------+--------------------------------------------------
Reporter: abergeron | Owner: abergeron
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-3.4
Component: graphics | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by was):
> I know you said you would prefer to include the list
> directly in the docstring, but I don't think this would be
> productive as it would require adding a doctest somewhere
> to check that the list has not changed and then when that
> breaks, have the one responsible manually update all the
> colormap lists, making sure to not forget every place where
> this info could have been copy and pasted and to fix the doctest.
> In short, it might be better, but I don't feel it is
> maintainable.
I very strongly disagree. I think you are saying the above because you
don't understand what I'm proposing. I'm just stating that the list
should appear in 1 or 2 places *only* in a doctest and nowhere else. This
is trivial to maintain.
> Now if there was some way to automatically
> include the current list in the docstrings, then that is
> another story.
That could certainly be done in Python (e.g., by playing tricks with the
method that gives the docstring), but it wouldn't necessarily be a good
idea. It would be fun as a challenge though :-)
Just for clarification, I'm 100% ok with this patch going in as is if
somebody else gave it a positive review. I don't think my suggestions are
at all something that should stop this getting a positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4884#comment:10>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
