#4884: [with patch; positive review] Make colormap handling better
-------------------------+--------------------------------------------------
Reporter: abergeron | Owner: abergeron
Type: enhancement | Status: reopened
Priority: major | Milestone: sage-3.3
Component: graphics | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by kcrisman):
* status: closed => reopened
* resolution: fixed =>
Comment:
Questions:
1. abergeron's last statement makes it sound like he *wants* the cmap_help
function back in, yet both patches were applied.
2. was' review implied that abergeron should let the ellipses below
{{{
<BLANKLINE>
The valid colormap names are:
...
}}}
be replaced by the actual output of cmap_help.
3. was' review also implies that for every function (e.g. matrix_plot)
where cmap is an option, that function's docstring should have as a
doctest a full call of cmap_help with its output, and that the review also
said it was okay if that didn't happen for this patch to go in. That
sounds like someone should have opened another ticket for this behavior.
Are any of these correct? Just checking; there has been a monumental
amount of fantastic work in 3.3!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4884#comment:13>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
