#5098: [with patch, with review, needs work] Pollard rho algorithm for generic
discrete logarithm
-------------------------+--------------------------------------------------
Reporter: ylchapuy | Owner: tbd
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.3
Component: algebra | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by cremona):
* summary: [with patch, needs review] Pollard rho algorithm for generic
discrete logarithm => [with patch, with review,
needs work] Pollard rho algorithm for generic
discrete logarithm
Comment:
I just wrote a review for this but trac refused to save it since another
comment has been made in between. How can it do this!!!! Luckily I was
able to use the "back" button to revover what I had written.
Review:
* Patch applied fine to 3.3.alpha2. Doctests in groups/generic pass.
* In the docstring for pollard_rho() I would move the explanation for
the partition_size parameter to a NOTE later, not in the description of
the paramater; and that description should say that the default is 16.
* There should be doctests in discrete_log() showing the use of the
algorithm parameter.
I also think that it would be helpful to add to this ticket (and perhaps
also in doctests) examples showing how the new algorithm is sometimes
preferable!
None of these is at all serious, and think this additoin is basically very
good.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5098#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
