#5130: [with patch; needs work] create a prime_pi function that doesn't just
compute len(prime_range(n))
---------------------------+------------------------------------------------
Reporter: was | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.3
Component: number theory | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by mhansen):
* summary: [with patch; needs review] create a prime_pi function that
doesn't just compute len(prime_range(n)) =>
[with patch; needs work] create a prime_pi
function that doesn't just compute
len(prime_range(n))
Comment:
Hi Andrew,
I think the code looks pretty good. There are two things that I'd like to
see added before it goes into Sage.
1. Could you add a reference for the algorithm being used? As part of
this, could you add docstrings to the two cdef functions briefly
describing their purpose / maybe relating them to the algorithm in the
reference?
2. Could you make a note about whether or not we'll run into any issues
with integer overflows or numerical accuracy as the code uses floating
point arithmetic (sqrt).
--Mike
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5130#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
