#13447: Make libsingular multivariate polynomial rings collectable
----------------------------------------------------------------+-----------
       Reporter:  nbruin                                        |         
Owner:  rlm                            
           Type:  defect                                        |        
Status:  needs_review                   
       Priority:  major                                         |     
Milestone:  sage-5.4                       
      Component:  memleak                                       |    
Resolution:                                 
       Keywords:                                                |   Work 
issues:  Input from a libsingular expert
Report Upstream:  None of the above - read trac for reasoning.  |     
Reviewers:                                 
        Authors:  Nils Bruin, Simon King                        |     Merged 
in:                                 
   Dependencies:  #11521                                        |      
Stopgaps:                                 
----------------------------------------------------------------+-----------
Changes (by SimonKing):

  * status:  needs_work => needs_review


Old description:

> Presently, #715 + #11521 help not permanently keeping parent in memory.
> In the process we uncovered a hard-but-consistently triggerable problem
> with the collection of `MPolynomialRing_libsingular`. We have only
> observed the problem on `bsd.math.washington.edu`, MacOSX 10.6 on x86_64.
>
> The present work-around is to permanently store references to these upon
> creation, thus preventing collection. It would be nice if we could
> properly solve the problem (or at least establish that the problem is
> specific to `bsd.math`)
>
> '''Unmerge''' #13145
>
> '''Apply'''
>
> #715, #11521, and then
>
>  * [attachment:trac_13447-consolidated_refcount.patch]
>  * [attachment:trac_13447-modulus_fix.patch]
>  * [attachment:trac_13447-rely_on_singular_refcount.patch]
>
> '''Merge together with''' #715, #11521

New description:

 Presently, #715 + #11521 help not permanently keeping parent in memory. In
 the process we uncovered a hard-but-consistently triggerable problem with
 the collection of `MPolynomialRing_libsingular`. We have only observed the
 problem on `bsd.math.washington.edu`, MacOSX 10.6 on x86_64.

 The present work-around is to permanently store references to these upon
 creation, thus preventing collection. It would be nice if we could
 properly solve the problem (or at least establish that the problem is
 specific to `bsd.math`)

 '''Apply'''

 #13145, #715, #11521, and then

  * [attachment:trac_13447-consolidated_refcount.patch]
  * [attachment:trac_13447-modulus_fix.patch]
  * [attachment:trac_13447-rely_on_singular_refcount.patch]

 '''Merge together with''' #715, #11521

--

Comment:

 The problems that I mentioned are now solved with the new patch version.

 Note that the new patch is relative to #13145, which I made a new
 dependency for #715.

 So, for the record:
 {{{
 $ hg qa
 trac_715_combined.patch
 trac_715_local_refcache.patch
 trac_715_safer.patch
 trac_715_specification.patch
 trac_11521_homset_weakcache_combined.patch
 trac_11521_callback.patch
 13145.patch
 trac_13447-consolidated_refcount.patch
 trac_13447-modulus_fix.patch
 trac_13447-rely_on_singular_refcount.patch
 }}}

 Let's keep the fingers crossed that the tests pass this time.

 Apply trac_13447-consolidated_refcount.patch trac_13447-modulus_fix.patch
 trac_13447-rely_on_singular_refcount.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13447#comment:41>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to