#13447: Make libsingular multivariate polynomial rings collectable
----------------------------------------------------------------+-----------
Reporter: nbruin |
Owner: rlm
Type: defect |
Status: needs_review
Priority: major |
Milestone: sage-5.4
Component: memleak |
Resolution:
Keywords: | Work
issues: Input from a libsingular expert
Report Upstream: None of the above - read trac for reasoning. |
Reviewers: Simon King
Authors: Nils Bruin, Simon King | Merged
in:
Dependencies: #11521 |
Stopgaps:
----------------------------------------------------------------+-----------
Comment (by SimonKing):
Concerning the last patch: I think one should rather use (as it is
"officially" recommended in the docs) `singular_ring_reference` and
`singular_ring_delete`, and not
{{{
if currRingHdl.data.uring!= currRing:
currRingHdl.data.uring.ref -= 1
if currRingHdl.data.uring.ref == 0:
rDelete(currRingHdl.data.uring)
currRingHdl.data.uring = currRing # ref counting?
currRingHdl.data.uring.ref += 1
}}}
Apart from that, I agree that the ring wrappers can be binned.
A bit later today, I will produce a combined patch, and provided that all
tests pass I will set it to positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13447#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
