#13501: Bugs in C3'salgorithm implementation in sage.misc.c3
-------------------------------------------+--------------------------------
       Reporter:  nthiery                  |         Owner:  nthiery     
           Type:  defect                   |        Status:  needs_review
       Priority:  major                    |     Milestone:  sage-5.4    
      Component:  categories               |    Resolution:              
       Keywords:  method resolution order  |   Work issues:              
Report Upstream:  N/A                      |     Reviewers:  Simon King  
        Authors:  Nicolas M. ThiƩry        |     Merged in:              
   Dependencies:  #12895                   |      Stopgaps:              
-------------------------------------------+--------------------------------

Comment (by nthiery):

 Replying to [comment:10 nthiery]:
 > > Apparently, after the line `next_item_found = False`, one should
 insert a `break`, because otherwise the loop is finished to no avail.
 >
 > Good point; I am trying it right now!

 Here it is: without the break:
 {{{
  2800/200    0.247    0.000    1.417    0.007 {sage.misc.c3.C3_algorithm}
 }}}

 with the break:
 {{{
  2800/200    0.243    0.000    1.413    0.007 {sage.misc.c3.C3_algorithm}
 }}}

 Tiny difference, but it's natural to put it here anyway. I am about to
 update the patch.

 Cheers,
                              Nicolas

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13501#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to