#13501: Fix two bugs in sage.misc.c3's implementation of the algorithm C3
-------------------------------------------------+--------------------------
Reporter: nthiery | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: categories | Resolution:
Keywords: method resolution order | Work issues:
Report Upstream: N/A | Reviewers: Simon King
Authors: Nicolas M. Thiéry, Simon King | Merged in:
Dependencies: #12895 | Stopgaps:
-------------------------------------------------+--------------------------
Comment (by nthiery):
Replying to [comment:22 SimonKing]:
> It seems to work!
>
> Hence, time for a cross-review...
>
> Apply trac_13501-categories-c3_fix-nt.patch trac_13501-c3-speedup-
sk.patch
I am almost ready for a postive review (assuming the patchbot goes green).
Two little questions: what happens if
- we use id(cat) rather than the obscure <size_t><void *> cat ?
- we use ``O in <set>tailsets[j]`` rather than assigning to a temporary
variable?
In both cases, if the speed is roughly equivalent, then I vote for the
more readable version.
Cheers,
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13501#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
