#13518: Additions for sensitivity analysis and mincost_okalg in glpk_backend
-------------------------------------------------------------------------------+
Reporter: christiankuper
| Owner: jason, jkantor
Type: enhancement
| Status: needs_review
Priority: major
| Milestone: sage-5.4
Component: numerical
| Resolution:
Keywords: out-of-kilter, sensitivity analysis, lp, linear programming
| Work issues:
Report Upstream: N/A
| Reviewers:
Authors: Christian Kuper
| Merged in:
Dependencies:
| Stopgaps:
-------------------------------------------------------------------------------+
Comment (by christiankuper):
Hello Nathann. Thanks for the feedback - comments are well taken.
Actually, I thought making changes visible would be helpful for the review
process, the intention was not gaining credits. As it is my first
contribution please excuse this "newbie" error. I will follow you advice
and rework the code.
Christian
> Hello Christian. Let's make this straight from the beginning : I am very
happy that you want to contribute to Sage, but what we are doing here is
write a software, not your resume. In your patch there are 11 additions of
your name inside of Sage's code. You add it to the documentation, you add
it to the source code as comments, you even add it before 3 lines in a
.pxd file where you import stuff from a library.
>
> Now Sage is a free software, and everybody's work should be credited
indeed. Your name will appear in Sage's release notes, it will appear on
this website. That's enough. We're not about to add our name to Sage's
source code each time we add one line, and the reason why you can still
read this file is that we don't.
>
> Well. You have not set this ticket to "needs_review", and judging from
things like
>
> {{{
> sage: p.write_ccdata("/home/chris/graph.dat")
> }}}
>
> it looks like you are still working on it. I will be glad to help with
the review proces when it will be ready (or even before, or whenever
needed), but in the meantime please try to imitate the writing style of
the source code in its current state.
>
> Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13518#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
