#13518: Additions for sensitivity analysis and mincost_okalg in glpk_backend
-------------------------------------------------------------------------------+
Reporter: christiankuper
| Owner: jason, jkantor
Type: enhancement
| Status: needs_review
Priority: major
| Milestone: sage-5.4
Component: numerical
| Resolution:
Keywords: out-of-kilter, sensitivity analysis, lp, linear programming
| Work issues:
Report Upstream: N/A
| Reviewers:
Authors: Christian Kuper
| Merged in:
Dependencies:
| Stopgaps:
-------------------------------------------------------------------------------+
Comment (by ncohen):
Helloooooooooo Christian !
Well, I asked a friend of mine about the message I sent yesterday -- as I
customarily get angry over trivial things -- and it looks like it was one
of these times again... Sage is one of the few things people still work on
for pleasure and not for money or anything, and these things are really
hard to find right now, so... `^^;`
About your patch : it is very large, and because it is one your first
there are many things to fix (trivial things that Sage developpers agreed
were necessary in a patch), and because your patch is so long... It shows.
But we'll fix that ! `:-)`
There are actually two important things to keep in mind :
* All the examples that are given in Sage's source code (inside of
each function) are used both by users when they wonder how the method
should be used, but also to automatically test sage. Before it is release,
we run "sage -t " on every file, and all tests have to pass. And no patch
is accepted whose "doctests" fail to pass. And of course a command like
p.write_ccdata("/home/chris/graph.dat") is only valid on your computer.
There's no /home/chris/ directory on mine ! Hence
{{{
sage -b && sage -t glpk_backend.pyx
}}}
would not pass tests on my computer. And all files should pass tests.
* The documentation that you write in each function is useful in this
text version, but it is also (badly) compiled to a html doc. That's how :
{{{
sage -b && sage -docbuild reference html
}}}
And of course the documentation should also be nicely displayed in
this html files. Sometimes one forgets to use `::` instead of `:`, and the
documentation misses something
Once more, do you consider your file needing a review or not yet ? It's
not a big decision to take : I just wonder whether I should spend the time
necessary to read, understand and make comments on your patch right now,
or whether you still work on the file at the moment. Actually, it would be
nice if you could try to fix those two things : documentation and
doctests, upate your patch, and then we'll begin the review.
Have fuuuuuuuun ! And thank you for your patch `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13518#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
