#12940: Combinatorial implementation of the affine symmetric group
-------------------------------------------------+--------------------------
Reporter: sdenton | Owner: tom denton
Type: enhancement | Status: new
Priority: minor | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: affine, combinatorics, days38 | Work issues:
Report Upstream: N/A | Reviewers:
Authors: tom denton | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------+--------------------------
Comment (by aschilling):
Hi Tom,
Without looking at the mathematics yet, here are some Sage specific
requirements that your patch does not yet fulfill:
- You need 100% coverage:
{{{
$affine_permutations anne$ sage -coverage affine_permutations.py
----------------------------------------------------------------------
affine_permutations.py
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE affine_permutations.py: 95% (46 of 48)
Missing doctests:
* __init__(self, parent, lst, check=True):
* random_element(self, n):
Possibly wrong (function name doesn't occur in doctests):
* _repr_(self):
* check(self):
* lower_covers(self,side="right"):
* _element_constructor_(self, *args, **keywords):
* _repr_(self):
* is_crystallographic(self):
* _an_element_(self):
}}}
- The preamble of your patch needs to start with #12940: Title + then a
summary of what this patch implements.
- The indents of your tests are not right for many of your methods. You
need
{{{
EXAMPLES::
sage: ....
}}}
Look at your documentation by building it via
{{{
sage -docbuild reference html
}}}
I can already see many places where you forgot ` for math display such as
in `\ZZ`.
So much for now,
Anne
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12940#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
