#12587: simplicial complexes lack hash function
------------------------------------+---------------------------------------
Reporter: vpilaud | Owner: sage-combinat
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.5
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Christian Stump
Authors: Travis Scrimshaw | Merged in:
Dependencies: #13244 #13590 | Stopgaps:
------------------------------------+---------------------------------------
Changes (by stumpc5):
* status: needs_review => needs_work
* reviewer: => Christian Stump
Comment:
Hi Travis,
I started to review the patch. Everything looks quite well, but you seem
to have missed handling the parameters properly, see below:
{{{
sage: S = SimplicialComplex(maximal_faces=[[1,4], [2,4]])
...
TypeError: 'NoneType' object is not iterable
}}}
and with this
{{{
sage: S = SimplicialComplex(vertex_set=[1,2,4],maximal_faces=[[1,4],
[2,4]])
sage: S
Simplicial complex with vertex set (1, 2, 4) and facets {(2, 4), (1, 4)}
}}}
The deprecation could maybe as well quickly be mentioned in the init of
!SimplicialComplex, since {{{vertex_set}}} is still there as an optional
argument.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12587#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
