#13747: Change default behaviour of Poset to facade = True
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by christiankuper):
Hello Nathann,
a few remarks from my side:
* Yes, the doc is better :-)
* I still don't feel very comfortable with the following facade doc: "
the `facade` variable will be set to `True` or `False` by a lower-level
call, or depending on the context." Depending on what context? I believe
the doc should clearly state what influence a certain parameter has.
* In the examples you sometimes changed the former default facade value
(i.e. facade = None) to facade = False, in other examples you left the
coding as it was so the examples work with the new defualt value facade =
True. (See 1st and 2nd example of Posets(...)). Not sure whether this was
done on purpose of forgotten
* I think there is one "`" to much in the Output doc of the constructor
(class FinitePoset)
Cheers
Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13747#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.