#13747: Change default behaviour of Poset to facade = True
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.6
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Christian Kuper
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by christiankuper):
Hello Nathann,
as far as I can judge there are no more issues with this patch:
* All test passed successfully
* The doc look ok
* The methods are behaving as promised in the doc (default behavior with
facade = True etc)
BTW, the explanation for the facade = True / False / None bevavior is much
clearer than in your first version ;-)
Just be clear about the extension of my review: I focused ONLY on the
changes you made. IMHO there is still room for improvment in this module,
as you stated earlier. ;-)
Good work!
Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13747#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
