#13747: Change default behaviour of Poset to facade = True
---------------------------------+------------------------------------------
       Reporter:  ncohen         |         Owner:  sage-combinat  
           Type:  defect         |        Status:  needs_work     
       Priority:  major          |     Milestone:  sage-5.6       
      Component:  combinatorics  |    Resolution:                 
       Keywords:                 |   Work issues:                 
Report Upstream:  N/A            |     Reviewers:  Christian Kuper
        Authors:  Nathann Cohen  |     Merged in:                 
   Dependencies:                 |      Stopgaps:                 
---------------------------------+------------------------------------------
Changes (by novoselt):

  * status:  needs_review => needs_work


Comment:

 The changes in `sage/geometry/fan.py` do not look OK to me:

 {{{
 f = f
 }}}
 Seriously???

 {{{
 'agree'
 }}}
 instead of
 {{{
 "agree"
 }}}
 just a change for the sake of change?

 {{{
 (e for e in level)
 }}}
 Not much better than the first one and it is repeated in
 `sage/geometry/cone.py`. If fixing doctests was done by some script/RE, it
 would be nice to read the result, especially if the code got changed, not
 just doctests as the patch name suggests.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13747#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to