#13784: Move methods from GenericGraph to Graph
--------------------------------+-------------------------------------------
       Reporter:  ncohen        |         Owner:  jason, ncohen, rlm
           Type:  defect        |        Status:  needs_review      
       Priority:  major         |     Milestone:  sage-5.6          
      Component:  graph theory  |    Resolution:                    
       Keywords:                |   Work issues:                    
Report Upstream:  N/A           |     Reviewers:  David Coudert     
        Authors:                |     Merged in:                    
   Dependencies:                |      Stopgaps:                    
--------------------------------+-------------------------------------------
Changes (by ncohen):

  * status:  needs_work => needs_review


Comment:

 Weird `O_o`

 I read the source code again, but the conclusion is the same : the cores
 method is not meant to be used on DiGraph... I mean : in this situation,
 it returns the same result as G.cores() on the underlying graph.

 I just added another patch that changes this `DiGraph` to a `Graph`, and
 tests pass afterwards. I do this in another patch so that the first one
 only moves methods around without modifying them. Thanks for noticing this
 !!!!

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13784#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to