#13826: Race condition in star_imports cache
--------------------------------+-------------------------------------------
Reporter: vbraun | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.5
Component: build | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Volker Braun | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Comment (by nbruin):
I think you're guarding a little too much in the `try: ... except` now.
Wouldn't we want to know if unpickling went wrong? We have a good reason
to catch errors from `open`: That's how we catch the file being
legitimately non-existent. I think it's a real error we want reported if
the file exists but doesn't contain a valid pickle. With your proposed
code one could end up with a corrupted cache and consistently, silently,
lose the efficiency of having the cache.
To some extent it's a matter of taste: Do you want to continue on a best-
effort basis as much as possible or do you want the user to know that
something didn't go as expected? I think the latter leads to an easier to
debug program and therefore is more suitable for sage.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13826#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
