#12215: Memleak in UniqueRepresentation, @cached_method
--------------------------------------------------------------+-------------
       Reporter:  vbraun                                      |         Owner:  
          
           Type:  defect                                      |        Status:  
needs_work
       Priority:  major                                       |     Milestone:  
sage-5.7  
      Component:  memleak                                     |    Resolution:  
          
       Keywords:  UniqueRepresentation cached_method caching  |   Work issues:  
          
Report Upstream:  N/A                                         |     Reviewers:  
Nils Bruin
        Authors:  Simon King                                  |     Merged in:  
          
   Dependencies:                                              |      Stopgaps:  
          
--------------------------------------------------------------+-------------

Comment (by SimonKing):

 Got it, I think.

 The crash happens in the last line of the following snippet
 {{{
   __pyx_t_1 = __pyx_v_self->D->buckets;
   __Pyx_INCREF(__pyx_t_1);
   __pyx_t_4 = __pyx_v_self->D->buckets;
   __Pyx_INCREF(__pyx_t_4);
   __pyx_t_10 = PyList_GET_ITEM(__pyx_t_1, (__pyx_v_h %
 PyList_GET_SIZE(__pyx_t_4)));
 }}}
 and according to the crash log, we have
 {{{
         __pyx_t_1 = 0x7f3db87dcb00 <_Py_NoneStruct>
 }}}

 Hence, again, we have the problem that some attributes have already become
 invalid. I think this was fixed by
 
[http://trac.sagemath.org/sage_trac/attachment/ticket/12313/trac_12313-safe_callback.patch
 the second patch] from #12313.

 Suggestion: In order to keep things modular, the part of the second #12313
 patch that applies to `TripleDict` shall be moved here, so that #12215
 remains independent of #12313. And then, the second patch of #12313 should
 be replaced by something that only takes care of the new `MonoDict`.

 Rationale: #12313 has a problem with a time regression, while #12215
 should (hopefully) be fine after installing the fix.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12215#comment:152>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to