#12215: Memleak in UniqueRepresentation, @cached_method
--------------------------------------------------------------+-------------
Reporter: vbraun | Owner:
Type: defect | Status:
positive_review
Priority: major | Milestone:
sage-5.7
Component: memleak | Resolution:
Keywords: UniqueRepresentation cached_method caching | Work issues:
Report Upstream: N/A | Reviewers:
Nils Bruin
Authors: Simon King | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------------------------+-------------
Changes (by nbruin):
* status: needs_review => positive_review
Comment:
Yes, this solves the problem here as well, so positive review.
It looks like the analysis on
[http://trac.sagemath.org/sage_trac/ticket/12313#comment:266 #12313:226]
and the patch that followed from it was based on this ticket. I probably
pulled the non-raw patches for #12313 when I tested ... Should we factor
out a utility from the Patchbot to pull and apply patches given a ticket
number?
Happy to see this work did find some use after all. Again, I believe that
in the future, when `TripleDictEraser` holds a weakref to its dictionary,
this won't be necessary anymore, because the weakref will be broken before
attributes on the dictionary get erased.
That enhanced traceback (including cython code!) is extremely cool. A big
thanks to Volker for making that happen. With that traceback, you only
only have to stare at the traceback to diagnose this problem.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12215#comment:154>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
