#13891: Default parameters for Graph.plot() and Graph.show()
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha,
Sébastien Labbé
Authors: Nathann Cohen | Merged in:
Dependencies: #13862 | Stopgaps:
---------------------------------+------------------------------------------
Comment (by ppurka):
Replying to [comment:40 ncohen]:
> (I just updated the patch so that graphplot stays as it was, along with
plot. The references to `GraphPlot.plot` have been replaced by
`GenericGraph.plot`, which takes all kind of arguments.)
>
> Nathann
Thanks. This is a huge mess.
I understand why the plot method is needed. If you look at the code for
`plot(f)` (the generic plot function) then, it returns the output
`f.plot()` method if it is present. I think the current patch is OK. I
also think slabbe is right in comment:41.
I have combined all the patches and made the [https://github.com/ppurka
/sage-patches/commit/a085570087caed97ee8cc9a2123438f1d6f0e34b 2-line
change] to `GenericGraph.plot`.
@slabbe - if you have no other problems with this patch, then you can set
it to positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13891#comment:43>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
